Search and Top Navigation
#3736 closed bug (fixed)
Opened January 02, 2009 07:27PM UTC
Closed May 26, 2011 09:47AM UTC
Last modified February 02, 2012 11:03AM UTC
Slider: some handles get stuck when using two or more handles
Reported by: | aksival | Owned by: | andrew_ |
---|---|---|---|
Priority: | major | Milestone: | 1.8 |
Component: | ui.slider | Version: | 1.6rc4 |
Keywords: | Cc: | ||
Blocked by: | Blocking: |
Description
To reproduce:
- Go here: http://ui.jquery.com/repository/tags/testing/demos/slider/range.html
- Drag the first handle to $0
- Drag the second handle to $0 and let go
- Now try dragging the handle
Bug occurs in IE, Mozilla, Opera, and Webkit browsers.
Attachments (4)
Change History (29)
Changed January 04, 2009 04:00AM UTC by comment:1
milestone: | TBD → 1.6 |
---|---|
priority: | major → critical |
Changed January 25, 2009 02:01PM UTC by comment:3
What about to 'bring to front' last touched handle?
Changed January 28, 2009 07:10PM UTC by comment:4
resolution: | → fixed |
---|---|
status: | new → closed |
Fixed in r1836.
Changed February 02, 2009 03:09AM UTC by comment:5
Fixed for ranges with a min value other than zero in r1953.
Changed March 22, 2009 09:02AM UTC by comment:6
Unfortunately this fix doesn't work where there are more than 2 handles (now that #4387 stops you dragging handles past each other and #4388 allows you to have a range with more than two handles). Possibly this should be opened as a new ticket since the fix was effective until I wrote the other two fixes?
Anyway, I have a solution which has sounder logic (I think!). We take the closest handle to be the highest one (as in the furthest right) rather than the lower one. This makes more sense to me anyway as I would expect the higher number to be top of the stack (until there is a fix for #3467).
Then if the closest handle is at the top value and the handle below that is also at the top value then we select the handle after. Rinse and repeat until we have the bottom handle of the stack (as it is either the last handle or because the handle below it is at a lower position on the slider). That's our active slider and the user can drag it downwards. No need to have any logic around range because when there is only one handle it will fall straight over the loop anyway...
See attached patch for more clarity.
Changed March 22, 2009 09:04AM UTC by comment:7
(didn't have permissions to re-open the ticket - will post to mailing list)
Changed March 22, 2009 06:45PM UTC by comment:8
Was told on the mailing list that it was incorrect to try and re-open this ticket because I noticed the problem after working on other tickets. However, the patch is still valid and the original fix doesn't fix the original problem.
See:
http://www.kelvinluck.com/assets/jquery/ui-slider/3736/buggy.html
Using latest ui.core and ui.slider from svn and the generated example page from the download app with one small change. range is set to false. Drag both sliders to the left. You now can't drag either slider...
Compare to the version with my patch:
http://www.kelvinluck.com/assets/jquery/ui-slider/3736/patched.html
Changed March 23, 2009 12:38AM UTC by comment:9
milestone: | 1.7 → 1.8 |
---|---|
resolution: | fixed |
status: | closed → reopened |
This still occurs with multiple handles and range: false.
Changed April 17, 2009 02:01PM UTC by comment:10
owner: | → andrew_ |
---|---|
status: | reopened → assigned |
Changed April 17, 2009 02:17PM UTC by comment:11
summary: | Second handle gets stuck when using two handles → Slider: some handles get stuck when using two or more handles |
---|
Changed April 17, 2009 07:46PM UTC by comment:12
The patch I have attached addresses the suspected issue: The original code assumes that there will only ever be two handles. When values.length > 2, the proposed patch ignores the 'otherVal' (value of the other of two handles) and proceeds with the value change/slide.
Changed April 20, 2009 03:15PM UTC by comment:13
resolution: | → fixed |
---|---|
status: | assigned → closed |
Committed fix to trunk. r2484.
Changed June 12, 2009 12:39PM UTC by comment:14
milestone: | 1.8 → 1.7.2 |
---|
Changed September 22, 2009 04:32PM UTC by comment:15
This issue was supposed to be fixed in 1.7.2 (latest release), but I'm still experiencing this issue, even after download and using the latest version.
This issue can also still be seen on the UI Slider demo page.
Changed September 22, 2009 04:46PM UTC by comment:16
Replying to [comment:17 gabriel]:
This issue was supposed to be fixed in 1.7.2 (latest release), but I'm still experiencing this issue, even after download and using the latest version. This issue can also still be seen on the UI Slider demo page.
Just downloaded jQuery UI 1.8a1 and the issue seems to be resolved. Nevermind.
Changed September 23, 2009 01:08AM UTC by comment:17
Replying to [comment:18 gabriel]:
> This issue was supposed to be fixed in 1.7.2 (latest release), but I'm still experiencing this issue, even after download and using the latest version. > > This issue can also still be seen on the UI Slider demo page. Just downloaded jQuery UI 1.8a1 and the issue seems to be resolved. Nevermind.
I stand corrected. I thought it was fixed, but it actually wasn't (see range demo). I've tried it on Firefox 3.5.2 & Safari 4.0.3 on OS X (Leopard).
Changed March 01, 2010 11:32PM UTC by comment:18
Submitting a patch to correctly handle the state where both handles are stacked on top of each other. Decides what handle to use based on which direction the mouse moves.
Changed March 01, 2010 11:33PM UTC by comment:19
Got error from trac when tried to upload the patch file. here it is http://dl.dropbox.com/u/144970/stackedHandles.diff
Changed October 18, 2010 01:20PM UTC by comment:20
resolution: | fixed |
---|---|
status: | closed → reopened |
Changed October 18, 2010 01:21PM UTC by comment:21
See #6193 for suggested change.
Changed October 19, 2010 03:45PM UTC by comment:22
priority: | critical → major |
---|
Changed January 03, 2011 01:34PM UTC by comment:23
#6797 is a duplicate of this ticket.
Changed January 13, 2011 01:35AM UTC by comment:24
milestone: | 1.7.2 → 1.9 |
---|
Changed February 10, 2011 03:10AM UTC by comment:25
I think I have some smarter selection logic for choosing which handle to move.
Commit https://github.com/ednark/jquery-ui/commit/7b80caa880038b9fedfc5d15b7d6209f904379f6
Changed May 26, 2011 09:47AM UTC by comment:26
milestone: | 1.9 → 1.8 |
---|---|
resolution: | → fixed |
status: | reopened → closed |
Not able to reproduce with any of the following:
- http://view.jqueryui.com/1.8/demos/slider/range.html
- http://view.jqueryui.com/1.8/tests/visual/slider/slider_ticket_3736.html
- http://view.jqueryui.com/1.8.13/demos/slider/range.html
- http://view.jqueryui.com/1.8.13/tests/visual/slider/slider_ticket_3736.html
- http://view.jqueryui.com/master/demos/slider/range.html
- http://view.jqueryui.com/master/tests/visual/slider/slider_ticket_3736.html
Changed June 10, 2011 03:51PM UTC by comment:27
I don't think that's fixed.
1. go to http://view.jqueryui.com/1.8.13/demos/slider/range.html
2. drag the right handler all the way to the left (so that it's on top of the left handler) using the mouse
3. let go of the mouse button
4. use the mouse to drag the handle to the right
Doesn't work in Firefox, Chrome .. and possibly others.
http://view.jqueryui.com/master/tests/visual/slider/slider_ticket_3736.html works - there is no restriction on the sliders so they can be moved freely -> you don't actually know which handler is used.
Changed June 10, 2011 05:20PM UTC by comment:28
Replying to [comment:29 schup]:
I don't think that's fixed. 1. go to http://view.jqueryui.com/1.8.13/demos/slider/range.html 2. drag the right handler all the way to the left (so that it's on top of the left handler) using the mouse 3. let go of the mouse button 4. use the mouse to drag the handle to the right
The issue you're describing is sufficiently captured in #3467 . This issue ( #3736 ) stands fixed as it is limited to both handles getting stuck when both are at the min because you click and it grabs the left handle and can't move it either to the left of the min or to the right of the right handle. See ticket description.
Changed February 02, 2012 11:03AM UTC by comment:29
#8093 is a duplicate of this ticket.
This occurs at any value. When the handles overlap, you can only drag the first.