Opened 10 years ago

Closed 7 years ago

Last modified 7 years ago

#4421 closed bug (fixed)

Dialog: Focus lost from dialog which uses show-effect

Reported by: qabi@… Owned by:
Priority: minor Milestone: 1.10.1
Component: ui.dialog Version: 1.7.1
Keywords: animation Cc:
Blocked by: Blocking:

Description

Hi,

When creating a dialog the first field is focused. When shown with an effect (like 'slide' or 'drop) the focus seems to be lost though (ends up on the root HTML element for some reason).

Can be worked around with a setTimeout(..) that is longer than the effect, but that's kind of nasty.

Change History (13)

comment:1 Changed 10 years ago by Jörn Zaefferer

Milestone: 1.7.21.8

comment:2 Changed 9 years ago by ajcrews

Related tickets: #4675, #4731, #5767

Fixed: http://github.com/ajcrews/jquery-ui/commit/1d1de7fc70501c25c6ff3de204c04078602baa04

Dialog: If a show animation is provided, the post-show code dependent on the dialog being ready occur in a callback function passed to the show method. Fixed #4421, 4675 - Focus lost from dialog which uses show effect.

comment:5 Changed 8 years ago by Scott González

Keywords: animation added; dialog focus effect removed

comment:6 Changed 7 years ago by Scott González

Milestone: 1.9.01.10.0

comment:7 Changed 7 years ago by dcarrith

Summary: Focus lost from dialog which uses show-effectDialog: Focus lost from dialog which uses show-effect

comment:8 Changed 7 years ago by dcarrith

This seems like a valid issue (even in jQuery UI 1.9) in IE9:

http://jsfiddle.net/n2qNw/1/

After the duration of 5000, the input loses focus.

Last edited 7 years ago by dcarrith (previous) (diff)

comment:9 Changed 7 years ago by dcarrith

Status: newopen

comment:10 Changed 7 years ago by Jörn Zaefferer

We were hoping for clip-based animations to address this. Its unclear if that will ever happen.

comment:11 Changed 7 years ago by tj.vantoll

Milestone: 1.10.0none

comment:12 Changed 7 years ago by Kris Borchers

Resolution: fixed
Status: openclosed

Dialog: Move call to _focusTabbable and triggering of open and focus events into the _show callback. Fixes #6756 - Dialog: show: "blind" with link in content doesn't animate properly. Fixes #8051 - Dialog: 'Explode' dialog animation causes crash in IE 6, 7 and 8. Fixes #4421 - Dialog: Focus lost from dialog which uses show-effect

Changeset: d1505e3434ef99e0068347a5e8179a0ffd737676

comment:13 Changed 7 years ago by Scott González

Milestone: none1.10.1
Note: See TracTickets for help on using tickets.