Opened 9 years ago

Closed 7 years ago

Last modified 7 years ago

#6756 closed bug (fixed)

Dialog: show: "blind" with link in content doesn't animate properly

Reported by: mjrjweb Owned by: mjrjweb
Priority: minor Milestone: 1.10.1
Component: ui.dialog Version: 1.8.4
Keywords: animation Cc:
Blocked by: Blocking:

Description

Blind effect on open (show) does not seem to go smoothly if there is a link in the dialog box. Previous version of jquery ui worked fine with link inside.
Did some testing and found that links in dialog work find with blind effect UNTIL jquery ui version 1.8.4.
I used latest version of jquery core.
Linkhttp://www.jensbits.com/demos/dialoglink.htm

Change History (12)

comment:1 Changed 8 years ago by Scott González

Keywords: animation added

comment:2 Changed 8 years ago by Scott González

Status: newopen

comment:3 Changed 8 years ago by Scott González

Summary: Link in dialog causes animation error with blind effect on openDialog: show: "blind" with link in content doesn't animate properly

comment:4 Changed 7 years ago by Scott González

Milestone: 1.9.01.10.0

comment:5 Changed 7 years ago by Jörn Zaefferer

This seems to work fine, not seeing any issue.

comment:6 Changed 7 years ago by mikesherov

Owner: set to mjrjweb
Status: openpending

In that case, I'll set this to pending on the off chance the OP has some repro steps. Mrjrweb, can you provide us more details?

comment:7 Changed 7 years ago by Jörn Zaefferer

The demo uses "latest" versions from the CDN, so its very likely that this was an issue 14 months ago and got fixed by now.

comment:8 Changed 7 years ago by Scott González

Status: pendingopen

Here's a proper test case: http://jsfiddle.net/mY9E2/ The animation is different because the dialog is shifted to make the focused anchor visible.

comment:9 Changed 7 years ago by Scott González

Chrome shows the animation as expected, all other browsers seem to have the same behavior.

comment:10 Changed 7 years ago by tj.vantoll

Milestone: 1.10.0none

comment:11 Changed 7 years ago by Kris Borchers

Resolution: fixed
Status: openclosed

Dialog: Move call to _focusTabbable and triggering of open and focus events into the _show callback. Fixes #6756 - Dialog: show: "blind" with link in content doesn't animate properly. Fixes #8051 - Dialog: 'Explode' dialog animation causes crash in IE 6, 7 and 8. Fixes #4421 - Dialog: Focus lost from dialog which uses show-effect

Changeset: d1505e3434ef99e0068347a5e8179a0ffd737676

comment:12 Changed 7 years ago by Scott González

Milestone: none1.10.1
Note: See TracTickets for help on using tickets.