#4534 closed bug (fixed)

Opened May 15, 2009 09:28PM UTC

Closed October 14, 2010 01:44PM UTC

Last modified October 25, 2010 06:56PM UTC

UI Dialog causing iframe to reload content every time 'show' is called

Reported by: bgrinstead Owned by:
Priority: minor Milestone: 1.8.6
Component: ui.dialog Version: 1.7.1
Keywords: iframe show dialog Cc:
Blocked by: Blocking:
Description

I recently ran into this problem. Basically, if you have an iframe inside your dialog content, every time you reshow the dialog, it reloads the iframe. This is unexpected and incorrect behavior. I have tracked down the change in the open function:

(uiDialog.next().length && uiDialog.appendTo('body'));

This line works - the iframe does not reload because the DOM is not being manipulated, I guess?

(uiDialog.parent().not('body').length && uiDialog.appendTo('body'));

Note: I found the fix here: http://www.nabble.com/-jquery.ui.dialog--Dailog-with-a-lot-of-HTML-unbearably-slow-td21257084s27240.html

Please take a look at this!

Thanks,

Brian Grinstead

Attachments (0)
Change History (6)

Changed May 17, 2009 01:19PM UTC by jzaefferer comment:1

milestone: TBD → 1.8

Changed July 28, 2009 10:25PM UTC by burnrbr comment:2

I experienced the same issue in Firefox.

I changed this code:

(uiDialog.next().length && uiDialog.appendTo('body'));

To:

if (uiDialog.next().length && uiDialog.get(0).parentNode != document.body)

{

uiDialog.appendTo('body');

}

Changed February 11, 2010 01:16PM UTC by Rwhitbeck comment:3

milestone: 1.8 → 1.next

Forum Post: http://forum.jquery.com/topic/ui-dialog-causing-iframe-to-reload-content-every-time-show-is-called

Changed May 10, 2010 01:13PM UTC by watanabe comment:4

Changed October 14, 2010 01:44PM UTC by scottgonzalez comment:5

milestone: 1.next → 1.9
resolution: → fixed
status: new → closed

Fixed in e66cdfc.

Changed October 25, 2010 06:56PM UTC by scottgonzalez comment:6

milestone: 1.9 → 1.8.6