#4534 closed bug (fixed)
UI Dialog causing iframe to reload content every time 'show' is called
Reported by: | bgrinstead | Owned by: | |
---|---|---|---|
Priority: | minor | Milestone: | 1.8.6 |
Component: | ui.dialog | Version: | 1.7.1 |
Keywords: | iframe show dialog | Cc: | |
Blocked by: | Blocking: |
Description
I recently ran into this problem. Basically, if you have an iframe inside your dialog content, every time you reshow the dialog, it reloads the iframe. This is unexpected and incorrect behavior. I have tracked down the change in the open function:
(uiDialog.next().length && uiDialog.appendTo('body'));
This line works - the iframe does not reload because the DOM is not being manipulated, I guess?
(uiDialog.parent().not('body').length && uiDialog.appendTo('body'));
Note: I found the fix here: http://www.nabble.com/-jquery.ui.dialog--Dailog-with-a-lot-of-HTML-unbearably-slow-td21257084s27240.html
Please take a look at this!
Thanks, Brian Grinstead
Change History (6)
comment:1 Changed 14 years ago by
Milestone: | TBD → 1.8 |
---|
comment:2 Changed 14 years ago by
comment:3 Changed 13 years ago by
Milestone: | 1.8 → 1.next |
---|
comment:5 Changed 13 years ago by
Milestone: | 1.next → 1.9 |
---|---|
Resolution: | → fixed |
Status: | new → closed |
Fixed in e66cdfc.
comment:6 Changed 13 years ago by
Milestone: | 1.9 → 1.8.6 |
---|
I experienced the same issue in Firefox.
I changed this code:
(uiDialog.next().length && uiDialog.appendTo('body'));
To:
if (uiDialog.next().length && uiDialog.get(0).parentNode != document.body) {
}