Skip to main content

Search and Top Navigation

#4589 closed bug (fixed)

Opened June 09, 2009 07:38PM UTC

Closed October 14, 2010 01:48PM UTC

Last modified October 25, 2010 06:52PM UTC

Modal dialog not retaining radio button selection

Reported by: kharpoh Owned by:
Priority: major Milestone: 1.8.6
Component: ui.dialog Version: 1.7.2
Keywords: Cc:
Blocked by: Blocking:
Description

Steps to reproduce.

1) Open dialog

2) Make any radio selection

3) Close dialog

4) Re-open dialog (Radio selection is missing)

It works for checkboxes.

Attachments (1)
Change History (8)

Changed June 09, 2009 08:27PM UTC by kharpoh comment:1

This is only an issue with IE.

Changed June 10, 2009 09:37AM UTC by jzaefferer comment:2

milestone: TBD1.8

Changed August 06, 2009 05:41PM UTC by jzaefferer comment:3

priority: criticalmajor

Doesn't seem to be related to DOM manipulations, at least there doesn't seem to happen any DOM element movements.

Considering this affects just radiobuttons in IE, it should be easy enough to implement a workaround (store the state before close, restore it on open).

Changed August 20, 2009 09:28AM UTC by jzaefferer comment:4

Though about checkboxes, but likely related: http://channel9.msdn.com/wiki/wiki/InternetExplorerProgrammingBugs/ (search for "checkbox" to get to the right section)

Changed May 10, 2010 04:45AM UTC by watanabe comment:5

See:

jQuery UI 1.8.1 uncompressed version.

jquery.ui.dialog.js

line 279(dialog open)

uiDialog.appendTo('body');

In IE6, "append" resets radio button selection.

Test Code:

$("#testButton").click(function () {
 $("#radioButtonsContainer").appendTo("body");
});

But I don't know what the line 279 means.

line 278

if (uiDialog.next().length) {

...Making uiDialog the last child of body to moveToTop?

But in line 284

self.moveToTop(true);

...Appending uiDialog to the DOM-Tree?

But in line 60(dialog _create)

.appendTo(document.body)

...already appended?

Changed May 10, 2010 04:51AM UTC by watanabe comment:6

See Ticket #4534, Ticket #3012.

Changed October 14, 2010 01:48PM UTC by scottgonzalez comment:7

resolution: → fixed
status: newclosed

Fixed in e66cdfc.

Changed October 25, 2010 06:52PM UTC by scottgonzalez comment:8

milestone: 1.91.8.6