#4681 closed bug (fixed)

Opened July 14, 2009 12:56PM UTC

Closed May 17, 2011 02:02PM UTC

Tabs: _sanitizeSelector needs to escape '.'

Reported by: liangent Owned by:
Priority: major Milestone: 1.9.0
Component: ui.tabs Version: 1.7.2
Keywords: Cc:
Blocked by: Blocking:
Description
45	        _sanitizeSelector: function(hash) {
46	                return hash.replace(/:/g, '\\\\:'); // we need this because an id may contain a ":"
47	        },

return hash.replace(/:/g, '\\\\:');
should be changed into something like 
return hash.replace(/([:\\.])/g, '\\\\$1');
. because dots can also cause problems.
Attachments (0)
Change History (6)

Changed November 17, 2009 05:57PM UTC by jzaefferer comment:1

milestone: TBD → 1.8

Changed February 28, 2011 03:43PM UTC by scottgonzalez comment:2

#6786 is a duplicate of this ticket.

Changed March 28, 2011 09:33PM UTC by fofanafi comment:3

status: new → open

Verified for jQuery UI 1.8.11. See duplicate bug for test case in jsFiddle and fix.

Changed May 11, 2011 02:06AM UTC by tomgallacher comment:4

Fixed in Github: https://github.com/jquery/jquery-ui/pull/244

Changed May 17, 2011 02:01PM UTC by scottgonzalez comment:5

summary: _sanitizeSelector needs to escape '.' → Tabs: _sanitizeSelector needs to escape '.'

Changed May 17, 2011 02:02PM UTC by Scott González comment:6

resolution: → fixed
status: open → closed

Tabs: Escape all special characters when sanitizing hash selectors. Fixes #4681 - Tabs: _sanitizeSelector needs to escape '.'.

Changeset: 5f10fa6511ae1965088926217776692a3f5663cb