#4752 closed bug (fixed)

Opened August 05, 2009 08:23PM UTC

Closed November 09, 2010 02:55PM UTC

Last modified December 08, 2010 06:35PM UTC

link event firing on sortable with connect list

Reported by: rambat Owned by:
Priority: minor Milestone: 1.8.7
Component: ui.sortable Version: 1.7.2
Keywords: Cc:
Blocked by: Blocking:
Description

If you have 2 sortable lists populated with links inside the unordered list elements dropping the element onto a connected list fires the click event.

Dropping on the same list does not fire the event.

Tested with 1.7.2.

You can duplicate this error by injecting a link into a list item on the demo page (http://jqueryui.com/demos/sortable/#connect-lists)

Then drag that item into the connected list.

Attachments (0)
Change History (6)

Changed November 18, 2009 07:51AM UTC by jzaefferer comment:1

milestone: TBD → 1.8

See also #4845.

Changed January 13, 2010 12:32AM UTC by jessicah comment:2

I just discovered this today as well, definitely a connectWith issue.

Haven't had it happen in IE8 yet, happens in Chrome and Firefox mostly consistently; occasionally it doesn't fire the link.

Changed August 15, 2010 09:57AM UTC by awgy comment:3

I ran into this issue as well. The click event isn't being prevented when the sorted item moves to a connected sortable. If the sorted item remains in its original list, the click event is properly prevented.

I tracked this down to the _preventClickEvent property used by ui.mouse. It's set to true in _mouseUp(), but it's set for the original container-- which is fine, unless the container changed (which is the case when the item moves to a connected sortable). I've pushed a patch to a GitHub fork that changes the click event prevention to be tied to the event target, not the container.

See GitHub fork commit

Changed August 15, 2010 10:04AM UTC by awgy comment:4

Correction: Please use the following GitHub commit link:

GitHub commit 15d1a0d

Changed November 09, 2010 02:55PM UTC by scottgonzalez comment:5

resolution: → fixed
status: new → closed

Fixed in e2a693b.

Changed December 08, 2010 06:35PM UTC by scottgonzalez comment:6

milestone: 1.9 → 1.8.7