Droppable: tolerance, pointer - bug when pointer outside draggable

[kevin.wells]

Use case

I have a draggable window for which the title bar acts as a handle. So it is only possible to drag the window by clicking in the title bar at the top of the window. I've set the containment of the window so it cannot be dragged outside the view port.

I have two droppable elements at the bottom of the view port, one on top of the other. The droppable elements are not as tall as the draggable. There is no way to drag the window onto the lowermost droppable.

I tried setting the tolerance of the droppable elements to pointer to resolve this problem. Even though I could move the pointer over the bottom droppable element I could not drop the window on the bottom element.

The problem occurs because the code in droppable assumes that the mouse pointer is always in the same position relative to the draggable that it was in when the user clicked the mouse to start dragging, or that it is always at the cursorAt position. This invariant does not hold when containment has been specified for the draggable and the draggable is close to the boundaries of the "container".

How to reproduce

I've attached a patch that adds a unit test to reproduce the problem.

How to fix

I've attached a patch that fixes the problem.

[Jörn Zaefferer]

Thanks for the patches.

[kevin-wells-iq4bis]

I've applied this patch to tag 1.8.4 and to the master branch. You can pull it from here:

​http://github.com/kevin-wells-iq4bis/jquery-ui/blob/3b7c347b03751deaae19875ff7ae1700e6455f1a

[wilhol]

I've submitted a pull request for this, updated to work on the current master. see ​https://github.com/jquery/jquery-ui/pull/991

[bhiggins]

FWIW, I've tested the pull request at ​https://github.com/jquery/jquery-ui/pull/991 against v1.10.3 and it works.

What's the next step here?

[bhiggins]

[accidental dup]

[Scott González]

#9655 is a duplicate of this ticket.

[mikesherov]

Adding fiddle from the most recent duplicate ​http://jsfiddle.net/joshgreifer/Y6KM9/

[Will Holley]

Droppable: only consider pointer location with tolerance "pointer"

Fixes #4977 Closes gh-991

Changeset: 87081b855c5ded96039d16791a30ff0181fb5a9f