buttons doesn't remove hover state if they are disabled

[AzaToth]

if hovering over a mouse and at the same time disable it, they hover state will not be removed. following patch fixes the issue by forcing removal even if diabled is set.

[Scott González]

A better fix would be to remove the classes when the button becomes disabled.

[AzaToth]

Replying to scott.gonzalez:

A better fix would be to remove the classes when the button becomes disabled.

Yea, that's an good idea, I've made an new patch to use that behavior.

[AzaToth]

remade patch to remove states on "disabled" directly

[AzaToth]

updated patch can be found at ​http://github.com/azatoth/jquery-ui/commit/3a282ebda4bef71275232dfb972ab30fd654a6e0

[Scott González]

#6808 is a duplicate of this ticket.

[Scott González]

This should be fixed by using the new ._hoverable() method being added to the base widget.

[fofanafi]

Here is a test case--after the button is disabled, the mouse is still in the hover state, although I'm not clear on whether this is an issue.

​http://jsbin.com/adika3/4

[Scott González]

If button can use ._hoverable(), that would solve this problem.

[BikingGlobetrotter]

I am using the second proposed patch, but it is not working as it should.

In the following example ​http://public.virtualmischa.de/bugs/jqueryui-button.html, you will see that after pressing "Play", "Stop" and "Play" the stop button is still in the hover state.

I tested it with Google Chrome. Firefox is even worse, because it is not removing hovering state for the play button with has not been disabled at all.

[cgack]

commit to use _hoverable found here: ​https://github.com/cgack/jquery-ui/commit/bc7d98e3df3385b2b737171dc6207d0ac3cb57e4

[Narretz]

Replying to cgack:

commit to use _hoverable found here: ​https://github.com/cgack/jquery-ui/commit/bc7d98e3df3385b2b737171dc6207d0ac3cb57e4

Hi, can you please reupload the ptch for hoverable? The link to your github depository is dead. I have the same problem - actually it is also possible to make the disabled radio buttons "active" which shouldnt't happen.

[gigi81]

I'm using 1.8.16 and encountered the same issue. Here is a jsFiddle that shows it: ​http://jsfiddle.net/gigi81/fav4R/3/

I don't understand why in 22 months the patch didn't make to the official stable release.

[Scott González]

@gig81: In 22 months, nobody has provided a patch that does the right thing. The right thing is to use a general purpose solution across all widgets, which is what I've mentioned multiple times in this ticket.

[jdomnitz]

what was the problem with the patch submitted by cgack?

[Scott González]

Replying to jdomnitz:

what was the problem with the patch submitted by cgack?

Presumably the problem that Narretz said? cgack did submit a pull request 4 months later (after my comment), we just haven't gotten around to reviewing it yet.

[gtr053]

A workaround I use for this is the following:

buttonObject.button('disable').blur().removeClass('ui-state-hover');

[mikesherov]

this ticket has a pull request: ​https://github.com/jquery/jquery-ui/pull/562

[Cory Gackenheimer]

Button: use _hoverable for hover state management. Fixes #5295 - button doesn't remove hover state if they are disabled

Changeset: 8e1ceba717b85e42a13cc1660e7c8e9e9c26c384

[Cory Gackenheimer]

Button: use _hoverable for hover state management. Fixes #5295 - button doesn't remove hover state if they are disabled (cherry picked from commit 8e1ceba717b85e42a13cc1660e7c8e9e9c26c384)

Changeset: 85b5c5b5586af541291d52e5c52b9774e4ec2a22

[Scott González]

#8829 is a duplicate of this ticket.