Skip to main content

Search and Top Navigation

#5393 closed bug (fixed)

Opened March 21, 2010 06:36PM UTC

Closed June 25, 2012 11:27PM UTC

getColor reports inaccurate color for transparent elements in Webkit

Reported by: Rwhitbeck Owned by: gnarf
Priority: major Milestone: 1.9.0
Component: ui.effects.core Version: 1.8
Keywords: color Cc:
Blocked by: Blocking:

I realize that getColor (from jquery.effects.core.js) is not an exposed function, but I did notice something odd about the logic which leads to it reporting incorrectly for transparent elements on Webkit. I copied getColor, getRGB and the 'colors' variable out into a simple example file with the latest jQuery and following contents:

Copy code

1. <div id="red" style="background-color:red;">

2. <div id="trans">

3. Some text.

4. </div>

5. </div>

And with the following call:

Copy code

1. alert(getColor($('#trans').get(0),'backgroundColor'));

Webkit (Chrome) will alert 255,255,255 while Firefox will alert 255,0,0

This is because there are two places in the code that handle transparency. Firefox (and I assume IE) transparency is caught in the do/while loop in getColor while Webkit transparency falls through to getRGB and is caught with a regular expression, thus returning colors['transparent'], which happens to be white.

Shouldn't getColor also handle the Webkit transparency something like this:

Copy code

1. if ( color != '' && color != 'transparent' && color != 'rgba(0, 0, 0, 0)' || $.nodeName(elem, "body") )

I saw mention of exposing getColor publicly and figured that this might be worth addressing before it's up for general use.

I've put together a working example of the issue and a copy of the getColor function with the logic moved so that it reports accurately for Webkit.


Attachments (0)
Change History (8)

Changed July 30, 2010 11:52AM UTC by jzaefferer comment:1

component: ui.coreeffects.core

Changed December 19, 2010 12:41PM UTC by aidan comment:2

There seems to be a fix for this suggested in

Changed January 07, 2011 05:25PM UTC by scottgonzalez comment:3

#6823 is a duplicate of this ticket.

Changed March 28, 2011 06:08PM UTC by gnarf comment:4

status: newopen

Changed April 27, 2011 09:17PM UTC by gnarf comment:5

owner: → gnarf
status: openassigned

Changed April 27, 2011 09:18PM UTC by gnarf comment:6

I'm going to be handling this in jQuery-color -- The expected return from should be "transparent"

Changed May 13, 2011 05:16PM UTC by gnarf comment:7

keywords: → color

Changed June 25, 2012 11:27PM UTC by Scott González comment:8

resolution: → fixed
status: assignedclosed

Upgrade to jquery-color 2.0pre. Fixes #6910 - Trying to animate the background color of a document fragment can easily fail. Fixes #5215 - Effects color: Add support for rgba animations. Fixes #4372 - Animate backgroundColor to 'transparent'. Fixes #5393 - getColor reports inaccurate color for transparent elements in Webkit. Fixes #3806 - Feature request: expose getRGB and getColor.

Changeset: 13d560b8f05a8eedbf28851824fe639a254f9fd0