Opened 6 years ago

Closed 6 years ago

Last modified 6 years ago

#5756 closed enhancement (fixed)

Widget: Use $.data instead of .data for performance reasons

Reported by: jzaefferer Owned by:
Priority: major Milestone: 1.8.3
Component: ui.widget Version: 1.8.2
Keywords: Cc:
Blocked by: Blocking:

Description

From http://forum.jquery.com/topic/please-try-not-use-element-data-in-widget:

The $(element).data() call is very expensive because it triggers setData/getData events, which in turn make some other .datat() calls. If the events are not needed, please use $.data(element, key, val) call which are much faster.


The jquery Widget has one expensive $(element).data() call on _createWidget:function(). This make creating hundreds of widget very slow. Please replace:
               this.element = $( element ).data( this.widgetName, this );
with
               this.element = $( element );
               $.data(element, this.widgetName, this );

Actually, many .data calls in the Widget use the $.data() form which is good.

But most such calls in the Draggable code use the evil $(this).data() call.

Someone should clean up all the other UI .js for the slow and unnecessary $(this).data() calls.

Setting the component to ui.widget for now, as optimizations in ui.widget, especially in the create method, affects everything.

Change History (5)

comment:1 Changed 6 years ago by jzaefferer

The upcoming changeData event will likely make the problem worse: http://github.com/jquery/jquery/commit/2e10af143b7eafb7142524f6534a62aee1910bd1

comment:2 Changed 6 years ago by jzaefferer

Fixed in b3940d2.

Created a new ticket for interactions: #5884.

comment:3 Changed 6 years ago by jzaefferer

  • Resolution set to fixed
  • Status changed from new to closed

comment:4 Changed 6 years ago by scottgonzalez

  • Milestone changed from 1.9 to 1.8.3

comment:5 Changed 6 years ago by jzaefferer

Replace element.data(...) with $.data(element, ...). Fixes #5756 - Widget: Use $.data instead of .data for performance reasons

Changeset: b3940d2f78dfcc37792ceb97e5659b78f156794c

Note: See TracTickets for help on using tickets.