Widget: Use $.data instead of .data for performance reasons
|Reported by:||jzaefferer||Owned by:|
The $(element).data() call is very expensive because it triggers setData/getData events, which in turn make some other .datat() calls. If the events are not needed, please use $.data(element, key, val) call which are much faster. The jquery Widget has one expensive $(element).data() call on _createWidget:function(). This make creating hundreds of widget very slow. Please replace: this.element = $( element ).data( this.widgetName, this ); with this.element = $( element ); $.data(element, this.widgetName, this ); Actually, many .data calls in the Widget use the $.data() form which is good. But most such calls in the Draggable code use the evil $(this).data() call. Someone should clean up all the other UI .js for the slow and unnecessary $(this).data() calls.
Setting the component to ui.widget for now, as optimizations in ui.widget, especially in the create method, affects everything.
Change History (5)
comment:3 Changed 6 years ago by jzaefferer
- Resolution set to fixed
- Status changed from new to closed
Note: See TracTickets for help on using tickets.