Search and Top Navigation
#6039 closed bug (fixed)
Opened September 09, 2010 03:15PM UTC
Closed March 14, 2013 11:09PM UTC
Droppable : disabled should not have ui-state-disabled
| Reported by: | wojes | Owned by: | |
|---|---|---|---|
| Priority: | major | Milestone: | 1.11.0 |
| Component: | ui.droppable | Version: | 1.8.2 |
| Keywords: | Cc: | ||
| Blocked by: | Blocking: |
Description
When disabling droppable element through its "disable" method, it gets ui-state-disabled.
It is not the case though when initializing the droppable through disabled option set to true.
This class sets the opacity of the element which is not desirable as droppable is an interaction (which should not affect the styling) not a widget
Attachments (0)
Change History (7)
Changed January 17, 2012 05:24AM UTC by comment:1
| _comment0: | Reproducible paste bin: http://jsfiddle.net/MByPK/1/ \ \ Shows it is the same with Draggable. \ \ Also shows an issue where the opacity of the `.ui-state-disabled, .ui-widget-content .ui-state-disabled, .ui-widget-header .ui-state-disabled` rule displays the div infront of the draggable's background (chrome & ff5/win 7). (If you disable the rule via the developer tools it shows in the correct place. Probably a browser bug.) \ \ Comment in ui.button.js: \ \ // TODO: pull out $.Widget's handling for the disabled option into \ // $.Widget.prototype._setOptionDisabled so it's easy to proxy and can \ // be overridden by individual plugins \ this._setOption( "disabled", options.disabled ); \ \ Would suggest this is an issue with all the widgets? Although maybe the display of the disabled widget is upto the css? \ \ → 1326777905782710 |
|---|
Changed October 11, 2012 09:07PM UTC by comment:2
| milestone: | TBD → 2.0.0 |
|---|
Changed March 12, 2013 02:10AM UTC by comment:4
| resolution: | → fixed |
|---|---|
| status: | open → closed |
Widget: Stop setting ui-state-disabled and aria by default on setting disabled option.
Fixes #5973 - Resizable: disabled should not have the ui-state-disabled class or aria attribute aria-disabled
Fixes #5974 - Draggable: disabled should not have the ui-state-disabled class or aria attribute aria-disabled
Fixes #6039 - Droppable : disabled should not have ui-state-disabled
Changeset: 4d67f4f34908a50ef88f95df4103ee001b777e45
Changed March 12, 2013 02:11AM UTC by comment:5
| milestone: | 2.0.0 → 1.10.2 |
|---|
Changed March 14, 2013 07:13PM UTC by comment:6
| milestone: | 1.10.2 → 1.11.0 |
|---|---|
| resolution: | fixed |
| status: | closed → reopened |
Reverted to keep this out of a patch release.
Changed March 14, 2013 11:09PM UTC by comment:7
| resolution: | → fixed |
|---|---|
| status: | reopened → closed |
Widget: Stop setting ui-state-disabled and aria by default on setting disabled option.
Fixes #5973 - Resizable: disabled should not have the ui-state-disabled class or aria attribute aria-disabled
Fixes #5974 - Draggable: disabled should not have the ui-state-disabled class or aria attribute aria-disabled
Fixes #6039 - Droppable: disabled should not have ui-state-disabled
This reverts commit 23771d38ba9d2663f6db0243c8e992dc7ff6844a.
Changeset: 44d07173db32b498e5f83f60db290ff1463daee3
Reproducible paste bin: http://jsfiddle.net/MByPK/1/
Shows it is the same with Draggable.
Also shows an issue where the opacity of the
.ui-state-disabled, .ui-widget-content .ui-state-disabled, .ui-widget-header .ui-state-disabledrule displays the div infront of the draggable's background (chrome & ff5/win 7). (If you disable the rule via the developer tools it shows in the correct place. Probably a browser bug.)Comment in ui.button.js:
// TODO: pull out $.Widget's handling for the disabled option into // $.Widget.prototype._setOptionDisabled so it's easy to proxy and can // be overridden by individual plugins this._setOption( "disabled", options.disabled );Would suggest this is an issue with all the widgets? Although maybe the display of the disabled widget is upto the css?