Opened 7 years ago

Closed 4 years ago

#6039 closed bug (fixed)

Droppable : disabled should not have ui-state-disabled

Reported by: wojes Owned by:
Priority: major Milestone: 1.11.0
Component: ui.droppable Version: 1.8.2
Keywords: Cc:
Blocked by: Blocking:

Description

When disabling droppable element through its "disable" method, it gets ui-state-disabled. It is not the case though when initializing the droppable through disabled option set to true. This class sets the opacity of the element which is not desirable as droppable is an interaction (which should not affect the styling) not a widget

Change History (7)

comment:1 Changed 5 years ago by JamesKhoury

Reproducible paste bin: http://jsfiddle.net/MByPK/1/

Shows it is the same with Draggable.

Also shows an issue where the opacity of the .ui-state-disabled, .ui-widget-content .ui-state-disabled, .ui-widget-header .ui-state-disabled rule displays the div infront of the draggable's background (chrome & ff5/win 7). (If you disable the rule via the developer tools it shows in the correct place. Probably a browser bug.)

Comment in ui.button.js:

    // TODO: pull out $.Widget's handling for the disabled option into    
    // $.Widget.prototype._setOptionDisabled so it's easy to proxy and can    
    // be overridden by individual plugins    
    this._setOption( "disabled", options.disabled ); 

Would suggest this is an issue with all the widgets? Although maybe the display of the disabled widget is upto the css?

Last edited 5 years ago by JamesKhoury (previous) (diff)

comment:2 Changed 5 years ago by Scott González

Milestone: TBD2.0.0

comment:3 Changed 5 years ago by mikesherov

Status: newopen

related to #5974 and #5973

comment:4 Changed 4 years ago by Mike Sherov

Resolution: fixed
Status: openclosed

Widget: Stop setting ui-state-disabled and aria by default on setting disabled option. Fixes #5973 - Resizable: disabled should not have the ui-state-disabled class or aria attribute aria-disabled Fixes #5974 - Draggable: disabled should not have the ui-state-disabled class or aria attribute aria-disabled Fixes #6039 - Droppable : disabled should not have ui-state-disabled

Changeset: 4d67f4f34908a50ef88f95df4103ee001b777e45

comment:5 Changed 4 years ago by mikesherov

Milestone: 2.0.01.10.2

comment:6 Changed 4 years ago by Scott González

Milestone: 1.10.21.11.0
Resolution: fixed
Status: closedreopened

Reverted to keep this out of a patch release.

comment:7 Changed 4 years ago by Scott González

Resolution: fixed
Status: reopenedclosed

Widget: Stop setting ui-state-disabled and aria by default on setting disabled option. Fixes #5973 - Resizable: disabled should not have the ui-state-disabled class or aria attribute aria-disabled Fixes #5974 - Draggable: disabled should not have the ui-state-disabled class or aria attribute aria-disabled Fixes #6039 - Droppable: disabled should not have ui-state-disabled

This reverts commit 23771d38ba9d2663f6db0243c8e992dc7ff6844a.

Changeset: 44d07173db32b498e5f83f60db290ff1463daee3

Note: See TracTickets for help on using tickets.