Opened 9 years ago

Closed 7 years ago

Last modified 7 years ago

#6727 closed bug (fixed)

Slider: Visual issues with disabled slider in IE8

Reported by: RwwL Owned by: tj.vantoll
Priority: minor Milestone: 1.10.0
Component: ui.slider Version: 1.8.6
Keywords: Cc:
Blocked by: Blocking:

Description

In IE8: only the slider track gets its opacity adjusted when a slider is disabled, not the thumb.

In IE7: both track and thumb get opacity adjustments when disabled, but the thumb is cropped to the height or width of a vertical or horizontal slider, respectively.

This bug is observable right on http://jqueryui.com/demos/slider/ if you use IE's JavaScript console to disable the sliders.

Change History (11)

comment:1 Changed 7 years ago by Scott González

Milestone: 1.9.01.11.0

comment:2 Changed 7 years ago by davenaeder

Status: newopen

Confirmed, this can be observed here: http://jsfiddle.net/davenaeder/Knyze/ in IE browsers

comment:3 Changed 7 years ago by tj.vantoll

Owner: set to tj.vantoll
Status: openassigned
Summary: visual issues with disabled slider in IESlider: Visual issues with disabled slider in IE8

This is an IE8 only issue, here's a better fiddle - http://jsfiddle.net/tj_vantoll/R8Jqx/. This has the same base problem as #6059, in IE8 non static positioned elements do not inherit the opacity of their parents.

I'll come up with something to fix this.

comment:4 Changed 7 years ago by tj.vantoll

I have a fix for this - http://jsfiddle.net/tj_vantoll/R8Jqx/11/show/, but there might be a bigger problem here. In all versions of IE when I disable the slider the handles simply seem to disappear. Anybody else seeing this?

I'm going to try it out on some real IE installations tomorrow to make sure that it's not a BrowserStack thing.

comment:5 Changed 7 years ago by Scott González

They don't actually disappear, they're just very light. Maybe try looking from a different angle to get more contrast from your monitor. If you increase the opacity, you'll see them better.

comment:6 Changed 7 years ago by tj.vantoll

Pull request: https://github.com/jquery/jquery-ui/pull/825

For a walkthrough of my logic that led to this unfortunate solution see the comments in the CSS box on this fiddle - http://jsfiddle.net/tj_vantoll/CFgDL/.

comment:7 Changed 7 years ago by TJ VanToll

Resolution: fixed
Status: assignedclosed

Slider: Explicitly apply opacity filter to disabled handles. Fixed #6727 - Slider: Visual issues with disabled slider in IE8

Changeset: 421aeaa08135e747ff9f2a59974c26b350cdcda7

comment:8 Changed 7 years ago by mikesherov

Milestone: 1.11.01.10.0

comment:9 Changed 7 years ago by Jörn Zaefferer

I've looked at merging this into 1-9-stable, but it won't apply cleanly, so ignoring it.

comment:10 Changed 7 years ago by mikesherov

joern, if you merge the CSS style changes first, it'll merge cleanly (I think).

comment:11 Changed 7 years ago by Scott González

Don't merge the style changes, just leave this for 1.10.0.

Note: See TracTickets for help on using tickets.