Skip to main content

Search and Top Navigation

#6979 closed bug (fixed)

Opened February 13, 2011 07:08AM UTC

Closed February 23, 2011 03:34PM UTC

Last modified March 29, 2012 10:14PM UTC

Several components are leaking variables into the global scope

Reported by: Licensed to Gil Owned by:
Priority: minor Milestone: 1.8.19
Component: [meta] ui.dev Version: 1.8.9
Keywords: Cc:
Blocked by: Blocking:
Description

I've found leaked global vars in the pulsate and size effects, as well as the accordion and slider widgets - mostly caused by using ; instead of , in var declarations.

GitHub pull request is coming - I need a bug number first ;)

This is filed under effects because I didn't think it was worth putting in three tickets for the three separate components when it's only a tiny fix in each file.

Attachments (0)
Change History (7)

Changed February 13, 2011 08:38AM UTC by Licensed to Gil comment:1

Changed February 14, 2011 02:31PM UTC by scottgonzalez comment:2

component: effects.* (individual effect)[meta] ui.dev

Changed February 23, 2011 03:34PM UTC by Gilmore Davidson comment:3

resolution: → fixed
status: newclosed

Fixed #6979 - Several components are leaking variables into the global scope

Changeset: 9626484dd5216f7597d4bb9680c95b9b210bac15

Changed March 29, 2012 10:05PM UTC by scottgonzalez comment:4

#8227 is a duplicate of this ticket.

Changed March 29, 2012 10:08PM UTC by felix comment:5

this is a fix for 1-8-stable

https://github.com/jquery/jquery-ui/pull/622

Changed March 29, 2012 10:14PM UTC by felix comment:6

Fixes #6979 - Several components are leaking variables into the global scope.

Changeset: 6fb584e7007bb7dc539d9c7266d17833c52a7830

Changed March 29, 2012 10:14PM UTC by scottgonzalez comment:7

milestone: 1.91.8.19