Opened 12 years ago
Closed 8 years ago
#7041 closed bug (fixed)
Toggle size effect demo not working
Reported by: | eccenux | Owned by: | mikesherov |
---|---|---|---|
Priority: | minor | Milestone: | 1.12.0 |
Component: | ui.effects.* (individual effect) | Version: | 1.8.9 |
Keywords: | Cc: | ||
Blocked by: | Blocking: |
Description
Steps
- Open page toggle demo.
- Select size effect.
- Click twice on Run effect.
Result
Background is not scaled back to the original size.
Not sure if this is a problem with demo options or with the "size" effect. Are there any options to make it work right?
Expected result
Toggle to the original size.
Change History (12)
comment:1 Changed 12 years ago by
Component: | [meta] ui.demos → effects.* (individual effect) |
---|
comment:2 Changed 12 years ago by
comment:3 Changed 12 years ago by
Status: | new → open |
---|
Reviewing the pull by kzys has got me wondering if .toggle("size")
makes any sense. We should at minimum document this to/from swapping behaviour and limit it to ONLY when using .toggle()
...
comment:4 Changed 12 years ago by
Also - Which direction do you think makes more sense to be from
vs to
? Showing goes to -> from
?
I would think that Showing goes from -> to
and hiding goes to -> from
, but only when your original mode is toggle
https://github.com/jquery/jquery-ui/pull/203#commitcomment-369756 might give you a better idea of a use case.
comment:5 Changed 12 years ago by
Owner: | set to kzys |
---|---|
Status: | open → assigned |
comment:6 Changed 10 years ago by
Milestone: | 1.9.0 → 1.10.0 |
---|
comment:7 Changed 10 years ago by
Cc: | Corey Frang scott.gonzalez added |
---|
There is a valid pull request still here! It was only closed because it no longer merged cleanly: https://github.com/jquery/jquery-ui/pull/203 If someone can rebase, perhaps it can be rescued... scott?
comment:8 Changed 10 years ago by
comment:9 Changed 10 years ago by
Keywords: | haspatch added |
---|
comment:10 Changed 10 years ago by
Milestone: | 1.10.0 → none |
---|
comment:11 Changed 8 years ago by
Cc: | Corey Frang scott.gonzalez removed |
---|---|
Keywords: | haspatch removed |
Milestone: | none → 1.12.0 |
Owner: | changed from kzys to mikesherov |
This will be fixed by the effects rewrite.
comment:12 Changed 8 years ago by
Resolution: | → fixed |
---|---|
Status: | assigned → closed |
Effects: Rewrite
- Introduces a set of helper methods to easily create and define new effects.
- Uses clip animations and placeholders instead of wrappers for clip effects.
- Ensures all animations are detectable as animated
Fixes #10599 Fixes #9477 Fixes #9257 Fixes #9066 Fixes #8867 Fixes #8671 Fixes #8505 Fixes #7885 Fixes #7041
Closes gh-1017
Changeset: b6bec797d6a8ef0b377a866c38c67e66a626b45f
https://github.com/jquery/jquery-ui/pull/203