Resizable: Containment calculation is wrong when containment element is not the immediate parent

[Hancoque]

There's a problem with the resizable component when using a containment element that is not the parent of the resizable element.

I found out that the allowed width computation differs from the allowed height computation. There's additional code for the former and it seems that a workaround for the bug is already in place but it is only triggered if the containment element is also the parent element:

var isParent = self.containerElement.get(0) == self.element.parent().get(0),
    isOffsetRelative = /relative|absolute/.test(self.containerElement.css('position'));

if(isParent && isOffsetRelative) woset -= self.parentData.left;

So, a possible approach to fix this bug is to get rid of the isParent check.

Test case: ​http://jsbin.com/oduba4

Try to resize the blue element to the full width of the gray element. It won't work, though it should. The space missing on the right equals the left offset of the containment element.

While investigating this bug I noticed that there are some other differences between the containment calculations for width and height in the same function as the code posted above is in. You may want to take a look at those differences as removing them also fixes the bug. But I don't know if these differences are there for a reason and address other issues.

Here's an additional subtraction of cop.left at the end:

self.size.width = self.size.width + (self._helper ? (self.position.left - co.left) : (self.position.left - cop.left));

vs

self.size.height = self.size.height + (self._helper ? (self.position.top - co.top) : self.position.top);}

And Here cop is used instead of co in the else-case:

var woset = Math.abs( (self._helper ? self.offset.left - cop.left : (self.offset.left - cop.left)) + self.sizeDiff.width ),

vs

    hoset = Math.abs( (self._helper ? self.offset.top - cop.top : (self.offset.top - co.top)) + self.sizeDiff.height );

[Hancoque]

The bug still exists in jQuery UI 1.8.14.

[tj.vantoll]

Still an issue in 1.9.1 - ​http://jsbin.com/oduba4/3.

[tj.vantoll]

#8217 is a duplicate of this ticket.

[tj.vantoll]

See duplicate ticket #8217 for a proposed patch.

[tj.vantoll]

#8895 is a duplicate of this ticket.

[tj.vantoll]

Here's another good test case from #8895 - ​http://jsfiddle.net/TkHUE/33/.

[tj.vantoll]

#9174 is a duplicate of this ticket.

[tj.vantoll]

#9174 had this test case against master - ​http://jsfiddle.net/v392b/. And a discussion on what the problem in the code might be.

[scato.eggen]

this bug is very easy to fix, so why has this issue been open for 21 months?

[Scott González]

@scato.eggen We've been very busy. Feel free to send a pull request with a unit test!

[tj.vantoll]

#9540 is a duplicate of this ticket.

[dekajp]

PRN -> ​https://github.com/jquery/jquery-ui/pull/1130

[Jyoti Deka]

Resizable: containment now works with non - immediate children

Fixes #7485 Closes gh-1130

Changeset: c03cb8079c6984fb9286a64d980d367d86b9cd8b