#8301 closed feature (fixed)
Sortable: Placeholder doesn't move when using connectWith option
| Reported by: | MoonScript | Owned by: | |
|---|---|---|---|
| Priority: | minor | Milestone: | 1.10.3 |
| Component: | ui.sortable | Version: | 1.8.20 |
| Keywords: | Cc: | ||
| Blocked by: | Blocking: |
Description
This is the same issue that was reported in #8274, but for connected lists (when using the "connectWith" option).
Issue can be seen here: http://jsfiddle.net/MoonScript/eba5T/show/
And I believe it should work like this: http://jsfiddle.net/MoonScript/eba5T/4/show/
Change History (12)
comment:2 Changed 10 years ago by
| Type: | enhancement → feature |
|---|
comment:3 Changed 10 years ago by
| Milestone: | 1.9.0 → 2.0.0 |
|---|
comment:5 Changed 9 years ago by
| Summary: | Placeholder doesn't move when using connectWith option → Sortable: Placeholder doesn't move when using connectWith option |
|---|
The test case showing the issue had some broken links so I fixed them and switched it to point at master: http://jsfiddle.net/tj_vantoll/GFLgF/.
The issue showing @MoonScript's fix could not be updated to master since his fix is embedded within a full jQuery UI include, but I fixed the broken CSS links: http://jsfiddle.net/tj_vantoll/LjR2P/.
comment:6 follow-up: 7 Changed 9 years ago by
It appears that this issue was fixed in version 1.10: https://github.com/jquery/jquery-ui/blob/master/ui/jquery.ui.sortable.js#L557-558
Commit here: https://github.com/jquery/jquery-ui/commit/b8b0c528301ab2bfc49e36143a3c4f6451e58ccd
UPDATE: My bad; I was looking at a previous commit of mine. Yes, this is still an open issue.
comment:7 Changed 9 years ago by
Replying to MoonScript:
It appears that this issue was fixed in version 1.10: https://github.com/jquery/jquery-ui/blob/master/ui/jquery.ui.sortable.js#L557-558
Commit here: https://github.com/jquery/jquery-ui/commit/b8b0c528301ab2bfc49e36143a3c4f6451e58ccd
Please close this ticket.
I'm still seeing the issue against master http://jsfiddle.net/tj_vantoll/GFLgF/.
comment:8 Changed 9 years ago by
Here's a new pull request with necessary tests! https://github.com/jquery/jquery-ui/pull/941
comment:9 Changed 9 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | open → closed |
Sortable: update placeholder when axis is x or y for connected lists. Fixed #8301 - Placeholder doesn't move when using connectWith option
Changeset: f306a826a4d3b4c36c3f86cb5feeee23bb0db4c3
comment:10 Changed 9 years ago by
| Milestone: | 2.0.0 → 1.11.0 |
|---|
comment:11 Changed 9 years ago by
Sortable: update placeholder when axis is x or y for connected lists. Fixed #8301 - Placeholder doesn't move when using connectWith option (cherry picked from commit f306a826a4d3b4c36c3f86cb5feeee23bb0db4c3)
Changeset: 9ac505b9fa747a24e5c329cde0614ec0fe49d807
comment:12 Changed 9 years ago by
| Milestone: | 1.11.0 → 1.10.3 |
|---|
Pull request with fix here: https://github.com/jquery/jquery-ui/pull/941