Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#8301 closed feature (fixed)

Sortable: Placeholder doesn't move when using connectWith option

Reported by: MoonScript Owned by:
Priority: minor Milestone: 1.10.3
Component: ui.sortable Version: 1.8.20
Keywords: Cc:
Blocked by: Blocking:

Description

This is the same issue that was reported in #8274, but for connected lists (when using the "connectWith" option).

Issue can be seen here: http://jsfiddle.net/MoonScript/eba5T/show/

And I believe it should work like this: http://jsfiddle.net/MoonScript/eba5T/4/show/

Change History (12)

comment:1 Changed 5 years ago by MoonScript

Last edited 5 years ago by MoonScript (previous) (diff)

comment:2 Changed 5 years ago by Scott González

Type: enhancementfeature

comment:3 Changed 5 years ago by Scott González

Milestone: 1.9.02.0.0

comment:4 Changed 5 years ago by Jörn Zaefferer

Status: newopen

Consider for redesign.

comment:5 Changed 5 years ago by tj.vantoll

Summary: Placeholder doesn't move when using connectWith optionSortable: Placeholder doesn't move when using connectWith option

The test case showing the issue had some broken links so I fixed them and switched it to point at master: http://jsfiddle.net/tj_vantoll/GFLgF/.

The issue showing @MoonScript's fix could not be updated to master since his fix is embedded within a full jQuery UI include, but I fixed the broken CSS links: http://jsfiddle.net/tj_vantoll/LjR2P/.

comment:6 Changed 5 years ago by MoonScript

It appears that this issue was fixed in version 1.10: https://github.com/jquery/jquery-ui/blob/master/ui/jquery.ui.sortable.js#L557-558

Commit here: https://github.com/jquery/jquery-ui/commit/b8b0c528301ab2bfc49e36143a3c4f6451e58ccd

UPDATE: My bad; I was looking at a previous commit of mine. Yes, this is still an open issue.

Last edited 5 years ago by MoonScript (previous) (diff)

comment:7 in reply to:  6 Changed 5 years ago by tj.vantoll

Replying to MoonScript:

It appears that this issue was fixed in version 1.10: https://github.com/jquery/jquery-ui/blob/master/ui/jquery.ui.sortable.js#L557-558

Commit here: https://github.com/jquery/jquery-ui/commit/b8b0c528301ab2bfc49e36143a3c4f6451e58ccd

Please close this ticket.

I'm still seeing the issue against master http://jsfiddle.net/tj_vantoll/GFLgF/.

comment:8 Changed 5 years ago by MoonScript

Here's a new pull request with necessary tests! https://github.com/jquery/jquery-ui/pull/941

comment:9 Changed 5 years ago by Jason Moon

Resolution: fixed
Status: openclosed

Sortable: update placeholder when axis is x or y for connected lists. Fixed #8301 - Placeholder doesn't move when using connectWith option

Changeset: f306a826a4d3b4c36c3f86cb5feeee23bb0db4c3

comment:10 Changed 5 years ago by mikesherov

Milestone: 2.0.01.11.0

comment:11 Changed 5 years ago by Jason Moon

Sortable: update placeholder when axis is x or y for connected lists. Fixed #8301 - Placeholder doesn't move when using connectWith option (cherry picked from commit f306a826a4d3b4c36c3f86cb5feeee23bb0db4c3)

Changeset: 9ac505b9fa747a24e5c329cde0614ec0fe49d807

comment:12 Changed 5 years ago by Scott González

Milestone: 1.11.01.10.3
Note: See TracTickets for help on using tickets.