Skip to main content

Search and Top Navigation

#9481 closed bug (fixed)

Opened August 06, 2013 12:31PM UTC

Closed August 26, 2014 11:25PM UTC

Last modified August 26, 2014 11:26PM UTC

Draggable: connectToSortable causes sortable revert to fail on second attempt

Reported by: djbutler Owned by: mikesherov
Priority: minor Milestone: 1.11.2
Component: ui.draggable Version: 1.10.3
Keywords: Cc:
Blocked by: Blocking:
Description

When a Draggable is dragged over a Sortable but then dropped outside the Sortable, the revert behavior of the Sortable is broken.

This example is actually straight from the Docs:

http://jqueryui.com/draggable/#sortable

http://jsfiddle.net/Vv5hT/

Drag the Draggable over the Sortable, but then drop it outside the Sortable. The revert behavior of the Sortable is now broken -- there is no revert animation anymore.

Attachments (0)
Change History (8)

Changed August 06, 2013 08:32PM UTC by tj.vantoll comment:1

owner: → djbutler
status: newpending

Hi djbutler,

Thanks for taking the time to contribute to the jQuery UI project.

I'm not seeing this behavior in Chrome, Firefox, or IE10. What browser / OS are you using?

Changed August 06, 2013 08:59PM UTC by djbutler comment:2

status: pendingnew

Thanks for the quick response tj.vantoll. Here, I made a better jsFiddle: http://jsfiddle.net/Vv5hT/1/

I've reproduced the behavior on Safari desktop/mobile and Chrome for OSX.

Changed August 08, 2013 07:17PM UTC by tj.vantoll comment:3

status: newopen
summary: connectToSortable revert fails on second attemptSortable: connectToSortable revert fails on second attempt

Thanks for that test case djbutler. I was expecting this to be a regression, but I see the same behavior in really old versions.

Hard to believe this hasn't come up before.

Changed August 24, 2014 01:26AM UTC by mikesherov comment:4

component: ui.sortableui.draggable
summary: Sortable: connectToSortable revert fails on second attemptDraggable: connectToSortable causes sortable revert to fail on second attempt

This is technically a bug in draggables conmectToSortabls implementation. Changing component.

Changed August 24, 2014 12:57PM UTC by mikesherov comment:5

owner: djbutlermikesherov
status: openassigned

I have a fix for this coming shortly.

Changed August 26, 2014 11:25PM UTC by Mike Sherov comment:6

resolution: → fixed
status: assignedclosed

Draggable: Ensure sortable revert still works after draggable is removed

Fixes #9481

Changeset: e8c99b9abf7ca9368668ee5886e469d31ea33c09

Changed August 26, 2014 11:25PM UTC by Mike Sherov comment:7

Draggable: Add battery of tests to cover connectToSortable

Refs #9481

Refs #9675

Closes gh-1323

Changeset: bfb65076e4727d4d7fc88561b0304853accb925c

Changed August 26, 2014 11:26PM UTC by mikesherov comment:8

milestone: none1.11.2