Opened 9 years ago

Closed 7 years ago

#5762 closed bug (fixed)

Dialog: Get rid of z-index workaround, document it instead

Reported by: Jörn Zaefferer Owned by:
Priority: major Milestone: 1.10.0
Component: ui.dialog Version: 1.8.2
Keywords: Cc:
Blocked by: Blocking:

Description

Currently the appendTo("body")-workaround for fixing z-index issues in IE6 causes more trouble then it solves, ie. http://forum.jquery.com/topic/dialog-will-move-its-div-tag-to-body

We should get rid of that workaround and instead document how manually apply it, via .dialog().dialog("widget").appendTo("body").

IE6 gets less important everyday, so we should move on, too. If this works for dialog, we can then do the same for other widgets that currently use the same workaround.

Change History (5)

comment:1 Changed 9 years ago by sslavic

Just got hit by this - expected dialog would be in container div, which was part of form; since dialog got moved out of form, any inputs in the dialog container div don't get submitted.

comment:2 in reply to:  1 Changed 7 years ago by zniki.ru

Replying to sslavic:

Just got hit by this - expected dialog would be in container div, which was part of form; since dialog got moved out of form, any inputs in the dialog container div don't get submitted.

Have the same problem.
There is solve and bug illustration.
jQuery 1.8.21
http://jsbin.com/awulib/2

Last edited 7 years ago by zniki.ru (previous) (diff)

comment:3 Changed 7 years ago by Scott González

Milestone: 1.9.01.10.0

comment:4 Changed 7 years ago by bavanyo

Status: newopen

comment:5 Changed 7 years ago by Nate Eagle

Resolution: fixed
Status: openclosed

Dialog: Awesome new stacking and overlay implementation. Fixes the following tickets:

Fixes #3534 - Dialog: Modal dialog disables all input elements on page. Fixes #4671 - Dialog: Modal Dialog disables vertical scroll bar in Chrome & Safari. Fixes #4995 - Dialog: Modal Dialog's overlay dissapears in IE when content is tall. Fixes #5388 - Dialog: Don't change z-index when already at the top. Fixes #5466 - Dialog: "modal" Dialog Incorrectly Cancels Input Events. Fixes #5762 - Dialog: Get rid of z-index workaround, document it instead. Fixes #6267 - Dialog: checkboxes that inherit a z-index < jqueryui.dialog z-index don't work. Fixes #7051 - Dialog: modal prevents tab key from moving focus off slider handle. Fixes #7107 - Dialog: Modal dialog event loss with high zindex child elements (FF 3.6). Fixes #7120 - Dialog: Modal operation interrupts drag drop marker functionality on gmaps. Fixes #8172 - Dialog: Change event cancelled when opening modal dialog from another modal dialog. Fixes #8583 - Dialog: Mouse event wrongly stopped. Fixes #8722 - Dialog: Remove stack option. Fixes #8729 - Dialog: Remove zIndex option.

Changeset: 3829a37ca122e923c3a08b964c4b1a946a2a1456

Note: See TracTickets for help on using tickets.