Skip to main content

Search and Top Navigation

#5762 closed bug (fixed)

Opened June 23, 2010 02:49PM UTC

Closed October 24, 2012 09:05PM UTC

Dialog: Get rid of z-index workaround, document it instead

Reported by: jzaefferer Owned by:
Priority: major Milestone: 1.10.0
Component: ui.dialog Version: 1.8.2
Keywords: Cc:
Blocked by: Blocking:
Description

Currently the appendTo("body")-workaround for fixing z-index issues in IE6 causes more trouble then it solves, ie. http://forum.jquery.com/topic/dialog-will-move-its-div-tag-to-body

We should get rid of that workaround and instead document how manually apply it, via .dialog().dialog("widget").appendTo("body").

IE6 gets less important everyday, so we should move on, too. If this works for dialog, we can then do the same for other widgets that currently use the same workaround.

Attachments (0)
Change History (5)

Changed December 11, 2010 10:18AM UTC by sslavic comment:1

Just got hit by this - expected dialog would be in container div, which was part of form; since dialog got moved out of form, any inputs in the dialog container div don't get submitted.

Changed July 29, 2012 08:43PM UTC by zniki.ru comment:2

_comment0: Replying to [comment:1 sslavic]: \ > Just got hit by this - expected dialog would be in container div, which was part of form; since dialog got moved out of form, any inputs in the dialog container div don't get submitted. \ \ Have the same problem.[[BR]] \ There is solve and big illustration.[[BR]] \ http://jsbin.com/awulib/21343594761940799

Replying to [comment:1 sslavic]:

Just got hit by this - expected dialog would be in container div, which was part of form; since dialog got moved out of form, any inputs in the dialog container div don't get submitted.

Have the same problem.

There is solve and bug illustration.

jQuery 1.8.21

http://jsbin.com/awulib/2

Changed October 11, 2012 02:47PM UTC by scottgonzalez comment:3

milestone: 1.9.01.10.0

Changed October 15, 2012 06:10PM UTC by bavanyo comment:4

status: newopen

Changed October 24, 2012 09:05PM UTC by Nate Eagle comment:5

resolution: → fixed
status: openclosed

Dialog: Awesome new stacking and overlay implementation. Fixes the following tickets:

Fixes #3534 - Dialog: Modal dialog disables all input elements on page.

Fixes #4671 - Dialog: Modal Dialog disables vertical scroll bar in Chrome & Safari.

Fixes #4995 - Dialog: Modal Dialog's overlay dissapears in IE when content is tall.

Fixes #5388 - Dialog: Don't change z-index when already at the top.

Fixes #5466 - Dialog: "modal" Dialog Incorrectly Cancels Input Events.

Fixes #5762 - Dialog: Get rid of z-index workaround, document it instead.

Fixes #6267 - Dialog: checkboxes that inherit a z-index < jqueryui.dialog z-index don't work.

Fixes #7051 - Dialog: modal prevents tab key from moving focus off slider handle.

Fixes #7107 - Dialog: Modal dialog event loss with high zindex child elements (FF 3.6).

Fixes #7120 - Dialog: Modal operation interrupts drag drop marker functionality on gmaps.

Fixes #8172 - Dialog: Change event cancelled when opening modal dialog from another modal dialog.

Fixes #8583 - Dialog: Mouse event wrongly stopped.

Fixes #8722 - Dialog: Remove stack option.

Fixes #8729 - Dialog: Remove zIndex option.

Changeset: 3829a37ca122e923c3a08b964c4b1a946a2a1456