Sortable: cancel method cannot be called in a beforeStop event handler

[tos1121]

line 1032 on "jquery.ui.sortable.js"

this.placeholder[0].parentNode is null in some condition.

[WRONG] this.placeholder[0].parentNode.removeChild(this.placeholder[0]);

[RIGHT] if(this.placeholder[0].parentNode)

this.placeholder[0].parentNode.removeChild(this.placeholder[0]);

thank you! --- Node.parentNode(Mozilla develop center) ​https://developer.mozilla.org/En/DOM/Node.parentNode

[scottgonzalez]

Can you provide an example of when this occurs?

[tos1121]

Replying to scott.gonzalez:

Can you provide an example of when this occurs?

Yes, This is the sample program.

​http://jsfiddle.net/jjgYf/

[scottgonzalez]

I'm not seeing any errors in the example.

[tos1121]

Replying to scott.gonzalez:

I'm not seeing any errors in the example.

I'm sorry, I mistook to tell you #6873 and #6054.

-- 「Table header sorting on Chrome break layout」　 ​http://bugs.jqueryui.com/ticket/6873

I'll comment later about this topic.

[tranver]

This issue still exists. I've created a simple test case at ​http://jsfiddle.net/zVpn5/1/
Tested with the following browsers:

• Google Chrome 12.0.742.122 (Windows 7)
• Firefox 5.0 (Windows 7, Mac OSX)

[scottgonzalez]

#7560 is a duplicate of this ticket.

[jdmarshall]

Based on a comment on ​http://forum.jquery.com/topic/problem-with-sortable-4-10-2010 I was able to narrow this down a bit.

If you provide a beforeStop callback, and the callback returns false (for instance, to disallow a drag operation based on business rules), this error will happen. Additionally, since there is no error handling in this code, once the error happens stop() is never called. This makes it very challenging to hook behavior on the beginning/end of drag operations.

There is a workaround. If beforeStop() has no return value, everything appears to work as expected. Simply using stop() for the whole operation may not suffice because some fields (eg, ui.helper) get cleared between these two calls. In that case, if you perform your checks in beforeStop() and return the value from stop(), then you can still cancel the actions, and you don't get the error.

[scottgonzalez]

#8340 is a duplicate of this ticket.

[tj.vantoll]

Test case against master - ​http://jsfiddle.net/tj_vantoll/dk9A4/.

The issue only occurs if you call the cancel method in a beforeStop event handler so I'm changing the description to be more indicative of the problem.

The error occurs on this line of the _clear method:

this.placeholder[0].parentNode.removeChild(this.placeholder[0]);

[tj.vantoll]

#7977 is a duplicate of this ticket.

[mebur]

in IE8 the following statement fails:

if(this.helper[0] !== this.currentItem[0]) {

and needs to be changed to:

if(this.helper!==null && this.helper[0] !== this.currentItem[0]) {

[scottgonzalez]

#10328 is a duplicate of this ticket.

[clinisbut]

I'm also experiencing this bug. In my case I'm just returning a false from beforeStop callback so

The issue only occurs if you call the cancel method in a beforeStop event handler so I'm changing the description to be more indicative of the problem.

while it is true, it also happens because returning false from beforeStop makes jQueryUI call the cancel method internally.

The point is _clear method is trying to remove the placeholder parent without checking if this parent still exists:

//$(this.placeholder[0]).remove(); would have been the jQuery way - unfortunately, it unbinds ALL events from the original node!
this.placeholder[0].parentNode.removeChild(this.placeholder[0]);

A simple check would fix this.

if (this.placeholder[0].parentNode) {
    //$(this.placeholder[0]).remove(); would have been the jQuery way - unfortunately, it unbinds ALL events from the original node!
    this.placeholder[0].parentNode.removeChild(this.placeholder[0]);
}