#8792 closed bug (fixed)
Sortable: Issue with floated items in connected lists
Reported by: | BlazeCell | Owned by: | mikesherov |
---|---|---|---|
Priority: | minor | Milestone: | 1.10.2 |
Component: | ui.sortable | Version: | 1.9.1 |
Keywords: | Cc: | ||
Blocked by: | Blocking: |
Description
The latest version of Sortable breaks when sorting floated items. It will only allow items to to be placed on the last row of a container.
Change History (21)
comment:1 Changed 10 years ago by
comment:2 Changed 10 years ago by
Owner: | set to BlazeCell |
---|---|
Status: | new → pending |
Thanks for taking the time to contribute to the jQuery UI project! Please provide a complete reduced test case on jsFiddle to help us assess your ticket.
Additionally, be sure to test against the git version of both jQuery UI and jQuery to ensure the issue still exists. To get you started, use this boilerplate: http://jsfiddle.net/ZgAqH/ Open the link and click to "Fork" (in the top menu) to get started.
Also the line that you're reverting (https://github.com/jquery/jquery-ui/commit/bae06d2b) was part of a change to fix #8572, #8573, and #8574.
comment:3 Changed 10 years ago by
Status: | pending → new |
---|
Additionally, be sure to test against the git version of both jQuery UI and jQuery to ensure the issue still exists. To get you started, use this boilerplate: http://jsfiddle.net/ZgAqH/ Open the link and click to "Fork" (in the top menu) to get started.
Thanks for the jsfiddle boilerplate, that helps to get things up and running quickly. =)
I've put together a jsfiddle with the same code I've performed my internal tests with: http://jsfiddle.net/BlazeCell/QkUft/8/
You can see the issue when you try to sort any of the items. The placeholder indicates that the sort action will drop the item on the last row, regardless of which sortable container you hover your mouse over. And when you release the mouse, the item will indeed be sorted to the bottom row.
comment:4 Changed 10 years ago by
Keywords: | haspatch added |
---|---|
Status: | new → open |
Summary: | Sortable on floating items only allows items to be placed on the last row. → Sortable: Issue with floated items in connected lists |
Minified this one down a little more - http://jsfiddle.net/tj_vantoll/rRDba/. I can confirm the issue in 1.9.1 and that it functions fine in 1.8.24. The issue only occurs when the connectWith
option is set and the items are floated.
comment:6 Changed 10 years ago by
I can verify that #8810 is probably the same bug.
Another JSFiddle with the issue: http://jsfiddle.net/arpowers/a7rxv/1/
comment:8 Changed 10 years ago by
Keywords: | haspatch removed |
---|---|
Owner: | changed from BlazeCell to mikesherov |
Status: | open → assigned |
comment:12 Changed 10 years ago by
Milestone: | 1.10.0 → none |
---|
comment:15 Changed 10 years ago by
Another test case from #9070: http://jsfiddle.net/tj_vantoll/vVrzf/
comment:16 Changed 10 years ago by
I've sent a pull request to fix this problem: https://github.com/jquery/jquery-ui/pull/916
comment:18 Changed 10 years ago by
comment:20 Changed 10 years ago by
Resolution: | → fixed |
---|---|
Status: | assigned → closed |
Sortable: Skip items that are not at the same line as the cursor when floating. Fixes #8792: Issue with floated items in connected lists.
Changeset: 89473f6557662d905a63faa3ae3520bf3715a7e8
comment:21 Changed 10 years ago by
Milestone: | none → 1.10.2 |
---|
Sortable: Reverted a line back to 1.8.24 version. Fixed #8792 - Sortable on floating items only allows items to be placed on the last row
The following github pull request has the fix: https://github.com/jquery/jquery-ui/pull/818