#9759 closed bug (notabug)
Dialog: Broken images on CDN and quick download
| Reported by: | Choppel | Owned by: | |
|---|---|---|---|
| Priority: | blocker | Milestone: | 1.11.0 |
| Component: | ui.dialog | Version: | 1.10.4 |
| Keywords: | Cc: | ||
| Blocked by: | Blocking: |
Description
When creating a modal dialog the background is not continuously one colour.
http://jqueryui.com/dialog/#modal http://jqueryui.com/dialog/#modal-confirmation
Change History (16)
comment:1 Changed 9 years ago by
| Status: | new → open |
|---|---|
| Summary: | Modal Dialog - Overlay is not continuous → Dialog - Issue with overlay image |
comment:3 Changed 9 years ago by
comparison of some images: http://jsfiddle.net/FlasJunior/zfEAQ/9/
comment:5 Changed 9 years ago by
| Milestone: | none → 1.11.0 |
|---|---|
| Priority: | minor → blocker |
comment:6 Changed 9 years ago by
| Summary: | Dialog - Issue with overlay image → Dialog: Broken images on CDN and quick download |
|---|
comment:8 follow-up: 9 Changed 9 years ago by
The resize icons on dialogs is broken as well; see http://jqueryui.com/dialog/#modal and notice that:
(i) the horizontal bar is there (set the background-image to none might fix this)
(ii) bottom right corner has resize handle but no icon (background image position is wrong)
comment:9 Changed 9 years ago by
Replying to schwarzenneger:
The resize icons on dialogs is broken as well
That's unrelated and not broken. See #4575.
comment:10 Changed 9 years ago by
Live download builder produces correct images. For example:
1.10.3: http://code.jquery.com/ui/1.10.3/themes/smoothness/images/ui-bg_flat_0_aaaaaa_40x100.png live: http://download.jqueryui.com/themeroller/images/ui-bg_flat_0_aaaaaa_40x100.png
Issue might have happened during release.
comment:11 Changed 9 years ago by
Although themeroller code is supposed to work using any ImageMagick version (https://github.com/jquery/download.jqueryui.com/issues/132). It's true for linux. But, not for mac (https://github.com/jquery/download.jqueryui.com/issues/144).
So, we need to either: (a) figure out what's wrong with #144 on Mac; or (b) release packages using a controlled environment.
comment:12 Changed 9 years ago by
| Resolution: | → notabug |
|---|---|
| Status: | open → closed |
We've addressed the cause of the issue, so I'm now going to close this, even though the CDNs will forever host the broken images. This will be closed as not a bug since it has nothing to do with the source code of jQuery UI.
Hmmm... it looks like something went wrong with the images generated in 1.10.4.
http://code.jquery.com/ui/1.10.3/themes/smoothness/images/ui-bg_flat_0_aaaaaa_40x100.png
vs
http://code.jquery.com/ui/1.10.4/themes/smoothness/images/ui-bg_flat_0_aaaaaa_40x100.png